Re: [libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE
On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote:
On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> This fixes a build for me with upstream libvirt.
NACK, per my reply to John's original patch, I think this should
not have been added to libvirt API in the first place.
I missed that. Looking at it now I was wondering why we have special
purpose, dedicated secrets to that they are used safely and now we have
general-purpose secret. OK, good to know, I haven't thought of that, I
just wanted to fix the test. Thanks for the info.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)