Re: [libvirt] [PATCH 5/6] Add security driver APIs for getting mount options

On 05/11/2012 06:10 AM, Daniel P. Berrange wrote: >From: Daniel Walsh<dwalsh(a)redhat.com> > >Some security drivers require special options to be passed to >the mount system call. Add a security driver API for handling >this data. > >Signed-off-by: Daniel P. Berrange<berrange(a)redhat.com> >--- >@@ -423,3 +422,16 @@ int virSecurityManagerSetImageFDLabel(virSecurityManagerPtr mgr, > virSecurityReportError(VIR_ERR_NO_SUPPORT, __FUNCTION__); > return -1; > } >+ >+char *virSecurityManagerGetMountOptions(virSecurityManagerPtr mgr, >+ virDomainDefPtr vm) >+{ >+ if (mgr->drv->domainGetSecurityMountOptions) >+ return mgr->drv->domainGetSecurityMountOptions(mgr, vm); >+ >+/* >+ I don't think this is an error, these should be optional >+ virSecurityReportError(VIR_ERR_NO_SUPPORT, __FUNCTION__); >+*/ Indentation -- or is my email program distorting it?