Re: [libvirt] [PATCH v4 4/7] udev: Convert udevEventHandleThread to an actual thread routine

[...] > > + while (1) { > > + virMutexLock(&privateData->lock); > > + while (privateData->nevents == 0 && !privateData->threadQuit) { > > + if (virCondWait(&privateData->threadCond, &privateData->lock)) { > > + virReportSystemError(errno, "%s", > > + _("handler failed to wait on condition")); > > Is a virMutexUnlock required before eventually calling virMutexDestroy... It is, but even an unlock wouldn't be enough, since there's concurrent access, even if everything goes smooth, the handle callback could be already waiting in queue to lock the mutex, which is too an undefined behaviour. So I'll change it so that the thread doesn't do any thread-local data cleanup (except for mutex unlock) and I'm going to add the free callback to virEventAddHandle, so that the data will be freed eventually.