Re: [libvirt] [PATCH v3 3/4] conf: storage: Don't emit empty <permissions> block
On 05/24/2015 07:38 AM, John Ferlan wrote:
On 05/21/2015 04:03 PM, Cole Robinson wrote:
> ---
> v3:
> New patch
>
> src/conf/storage_conf.c | 42 +++++++++++++---------
> tests/storagepoolxml2xmlout/pool-netfs-gluster.xml | 2 --
> tests/storagevolxml2xmlout/vol-gluster-dir.xml | 2 --
> tests/storagevolxml2xmlout/vol-sheepdog.xml | 2 --
> 4 files changed, 26 insertions(+), 22 deletions(-)
>
ACK - although I suppose it could be combined with 2/4, but I'm OK with
it being separate.
I intentionally kept them separate since I didn't want to mix up functional
changes with a cosmetic output change.
Pushed this and patch #4 as is. Thanks for the review!
- Cole