Re: [Libvir] Re: [PATCH] add missing qemudReportError
On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote:
On Tue, Feb 05, 2008 at 01:06:14PM +0100, Guido Guenther wrote:
> without this qemudParseVMDef might return NULL when the boot dev
> configuration is invalid but virGetLastError returns NULL either since
> no error has been set, this leads to a segfault in qemudLoadConfig when
> trying to print the error message.
That said it might also be worthwhile to not let libvirtd segfault
because of a missing call to qemudReportError - this is debatable
though:
ACK to both patches. Any & all scenarios which can cause a crash must
be fixed.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|