Re: [libvirt] [PATCH 1/2] tool/virsh-domain.c: Add a vshNodeGetCPUMap function to get cpumap of host.
On 05/24/2013 08:18 PM, Peter Krempa wrote:
On 05/24/13 11:21, yangdongsheng wrote:
> Get CPU map of host node CPUs by trying virNodeGetCPUMap
> and falling back to virNodeGetCPUStats.
>
> Signed-off-by: yangdongsheng <yangds.fnst(a)cn.fujitsu.com>
> ---
> tools/virsh-domain.c | 55
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
NACK. This functionality is already implemented as "nodecpumap"
command defined in cmdNodeCpuMap in virsh-host.c
If you wish to add the fallback code to that function, the patch is
welcome.
Peter
Aha, I see it.
But now, I think the fallback is not nessary. We can use
virNodeGetCPUMap directly.
Thanx for your reply. :)