Re: [PATCH 1/3] docs: formatdomain: Mention the QEMU version for igb
On 7/28/23 10:09, Han Han wrote:
Signed-off-by: Han Han <hhan(a)redhat.com>
---
docs/formatdomain.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index cd9cb02bf8..97ab367cff 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -5446,7 +5446,7 @@ Typical values for QEMU and KVM include: ne2k_isa i82551 i82557b
i82559er
ne2k_pci pcnet rtl8139 e1000 virtio. :since:`Since 5.2.0` ,
``virtio-transitional`` and ``virtio-non-transitional`` values are supported.
See `Virtio transitional devices`_ for more details.
-:since:`Since 9.3.0` igb is also supported.
+:since:`Since 9.3.0(QEMU 8.0)` igb is also supported.
Missing space to separate libvirt version and '('. But then I am
wondering how useful this is. We usually don't document hypervisor
version, because especially QEMU is notoriously known to have active
downstream developers who backport even features (that's the whole
reason we have QEMU capabilities and try to avoid version checks as much
as possible).
Looking from another angle, the worst thing that will happen is: QEMU
refuses to start because of unknown NIC model. Well if that doesn't
suggest to the user to upgrade then I don't think our docs would.
Michal