Re: [libvirt] lxc_controller: don't ignore failed "accept"
On 05/20/2010 09:40 AM, Jim Meyering wrote:
>From d4bebc04bf701e81efdd9d68ceb5b179a625e1db Mon Sep 17 00:00:00
2001
From: Jim Meyering <meyering(a)redhat.com>
Date: Thu, 20 May 2010 14:30:36 +0200
Subject: [PATCH] lxc_controller.c: don't ignore failed "accept"
* src/lxc/lxc_controller.c (ignorable_epoll_accept_errno): New function.
(lxcControllerMain): Handle a failed accept carefully:
most errno values indicate legitimate failure and must be fatal.
However, ignore a special case: that in which an incoming client quits
between the poll() indicating its presence, and our accept() which
is trying to process it.
Ah, it took me a bit to understand this. But I think this is the
right solution, since we don't want the controller to die if a
client happens to disconnect at the wrong time.
ACK
--
Chris Lalancette