Re: [libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

Hi, On Fri, Sep 26, 2014 at 12:43:08PM +0200, Martin Kletzander wrote: > This patch implements support for the ivshmem device in QEMU. > > Signed-off-by: Maxime Leroy <maxime.leroy(a)6wind.com&gt; > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > > - Nitpicks shall follow! :) What's this? > /* > * This method takes a string representing a QEMU command line ARGV set > * optionally prefixed by a list of environment variables. It then tries > diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h > index aa40c9e..5083223 100644 > --- a/src/qemu/qemu_command.h > +++ b/src/qemu/qemu_command.h > @@ -131,6 +131,7 @@ char *qemuBuildDriveDevStr(virDomainDefPtr def, > char *qemuBuildFSDevStr(virDomainDefPtr domainDef, > virDomainFSDefPtr fs, > virQEMUCapsPtr qemuCaps); > + And this whole hunk?