Re: [libvirt] [PATCH 10/14] secret: Create a 'base64File' in virSecretObj
On Thu, Feb 25, 2016 at 09:03:14AM -0500, John Ferlan wrote:
This patch removes need for secretBase64Path and secretComputePath.
Similar
to the configFile, create an entry for base64File, which will be generated
as the driver->configDir, the UUID value, plus the ".base" suffix. Rather
than generating on the fly, store this in the virSecretObj.
The buildup of the pathname done in loadSecrets where the failure to build
is ignored which is no different than the failure to generate the name
in secretLoadValue which would have been ignored in the failure path
after secretLoad.
Yep, and better to have the failure upfront than later when we want to
save/delete the secret
This also removes the need for secretComputPath and secretBase64Path.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/secret/secret_driver.c | 107 ++++++++++++++++++++-------------------------
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|