Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

On Tue, Oct 21, 2008 at 03:10:15PM -0400, Ben Guthro wrote: Okay, I commited the set of patches to CVS, congratulations (also added you to the AUTHORS list as a result) ! I made the changes that Dan and I suggested before commiting. There is just a couple of things I did in addition, I may have been a bit over zealous in discarding virEventHandleType enums, I also replaced them by ints in internal APIs where not used as set. I think the only thing we loose is compiler checkings/warning in case of switch {} constructs, but I'm still worried about them as arguments even internally. Otherwise I also changed virStringListFree to __virStringListFree and virStringListJoin to __virStringListJoin to make clear they are not exported from libvirt.c, but that's not related to your patches. Again congratulations ! I think this also means the next release will be a 0.5.0 since this is a major API addition. I still looking at the other pending patches though, it would be better to have them in the next release ... oh and I want your java bindings and we need Python too (and QPid !) :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/