On Tue, Nov 16, 2010 at 04:16:40PM -0700, Eric Blake wrote:
* cfg.mk (sc_prohibit_sprintf): New rule.
(sc_prohibit_asprintf): Avoid false positives.
* docs/hacking.html.in (Printf-style functions): Document the
policy.
* HACKING: Regenerate.
* .x-sc_prohibit_sprintf: New exemptions.
* Makefile.am (syntax-check_exceptions): Ship new file.
* src/vbox/vbox_tmpl.c (vboxStartMachine, vboxAttachUSB): Use
virAsprintf instead.
* src/uml/uml_driver.c (umlOpenMonitor): Use snprintf instead.
* tools/virsh.c (cmdDetachInterface): Likewise.
* src/security/security_selinux.c (SELinuxGenSecurityLabel):
Likewise.
* src/openvz/openvz_driver.c (openvzDomainDefineCmd): Likewise,
and ensure large enough buffer.
---
diff in v3 - rebase on top of my pending patch to update gnulib
diff in v2 - actually include the changes to src/vbox/vbox_templ.c
.x-sc_prohibit_sprintf | 4 +++
HACKING | 6 +++++
Makefile.am | 1 +
cfg.mk | 13 ++++++++--
docs/hacking.html.in | 9 +++++++
src/openvz/openvz_driver.c | 5 ++-
src/security/security_selinux.c | 6 ++--
src/uml/uml_driver.c | 3 +-
src/vbox/vbox_tmpl.c | 46 +++++++++++++++++++++++++-------------
tools/virsh.c | 2 +-
10 files changed, 69 insertions(+), 26 deletions(-)
create mode 100644 .x-sc_prohibit_sprintf
ACK
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://deltacloud.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|