Re: [libvirt] [PATCH v6 11/11] quorum: Block snapshot operation with RAID
On Thu, Oct 29, 2015 at 14:43:19 +0100, Matthias Gatto wrote:
For now we block all snapshot operations with quorum, because it
would require
a lot more code, espacially because Qemu doesn't really suport it.
Snapshots aren't the only thing that will not work. Basically every
other block operation needs to be either checked that it works or it has
to be forbidden too. Namely: blockRebase, blockPull, blockCopy (this
will probably work, if not used as a target), and possibly other I now
can't remember.
I guess, we can use node-name, and manually snapshoot all qcow from a
virStorageSource and use this as a quorum's snapshot,
but libvirt doesn't support node-name, and we don't need node-name
anymore to use a quorum in qemu.
In libvirt we actually do want to start using node names. It's the only
way to do some more complex operations.
I actually have some patchs which could partially support quorum snapshot
on my computer, but nothing suitable to be upstream, so I prefer to have
a stable versions of quorum inside libvirt before dealling with
snapshot.
This paragraph doesn't belong to a commit message.
Signed-off-by: Matthias Gatto <matthias.gatto(a)outscale.com>
---
src/qemu/qemu_driver.c | 6 ++++++
1 file changed, 6 insertions(+)
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)