Re: [Libvir] PATCH: More useful error messages with missing certs

On Wed, Jul 11, 2007 at 04:10:10PM -0400, Daniel Veillard wrote: > > +#define CHECK_CERT(type, file) \ > > + do { if (stat(file, &sb) < 0) { \ > > + qemudLog (QEMUD_ERR, "Cannot access " type " '%s': %s (%d)", \ > > + file, strerror(errno), errno); \ > > + return -1; \ > > + } } while (0) > > + > > Why not make a function instead of this convoluted construct ? > And same in src/remote_internal.c too. I committed with that suggested change - the compiler will probably inline the function anyway.