On 03/09/2010 03:25 PM, Eric Blake wrote:
* src/remote/remote_driver.c (remoteIO, remoteIOEventLoop): Report
failures on pipe used for wakeup.
Reported by Chris Lalancette.
---
I think this is what you had in mind for additional error
checking. However, in practice, will one-byte reads and
writes on fd's created by pipe() ever encounter any errors?
+ s = safewrite(priv->wakeupSendFD, &ignore, sizeof(ignore));
+ if (s < 0) {
+ errorf(flags & REMOTE_CALL_IN_OPEN ? NULL : conn,
+ VIR_ERR_INTERNAL_ERROR,
+ _("failed to wake up polling thread: %s"),
+ strerror(errno));
Of course, this patch (and also 1/2) fails 'make syntax-check', thanks
to strerror. Yet another respin coming.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org