On Thu, Jan 03, 2013 at 02:16:12PM -0500, John Ferlan wrote:
Bug:
https://bugzilla.redhat.com/show_bug.cgi?id=880388
This set of patches resolves the "CHECKED_RETURN (CWE-252)" errors found
by Coverity.
John Ferlan (10):
interface: Check and handle error for virAsprintf() calls.
parallels: Check and handle error for virAsprintf() calls. Ignore the return
inparallelsMakePoolName() since subsequent check validates name
was allocated.
rpc: Check status when attempting to set SO_REUSEADDR flag on outgoing
connection. On failure, VIR_WARN(), but continue to connect.
vmware: Ignore the return status check for vmwareUpdateVMStatus in
convenience routine vmwareDomainObjListUpdateDomain
xen: Check return status for setting TCP_NODELAY option and generate a
VIR_DEBUG message on failure. Allow connection to continue.
virlockspacetest: Check return on mkdir for LOCKSPACE_DIR
vmx2xmltest: Check and handle error for virAsprintf() calls.
xml2vmxtest: Check and handle error for virAsprintf() calls.
virsh: Ignore error returns for virBufferTrim().
phyp: Check and handle select() errors from waitsocket().
There are a number of issues with vifAsprintf(). As a further patch I
think you should add ATTRIBUTE_RETURN_CHECK to this function, so we
see the problems immediately rather than relying on coverity.
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|