Re: [PATCH] build: Require glib >= 2.56
On Tue, Mar 02, 2021 at 08:51:29AM +0100, Peter Krempa wrote:
On Mon, Mar 01, 2021 at 16:00:47 -0700, Jim Fehlig wrote:
> There are a few uses of g_autoslist in the qemu driver and likely
> more will come throughout the codebase in the future. g_autoslist
> first appeared in glib 2.56, so bump the minimum version.
>
> https://developer.gnome.org/glib/stable/glib-Miscellaneous-Macros.html#g-...
Hmm, oops g_autoslist was my doing, unfortunately I thought we had
guards in place to prevent using stuff from newer glib.
Yes, but the guards aren't perfect. The rely on being able to attach
deprecation attributes to functions, and g_autoslist is a macro so
doesn't get the guard.
Our CI is supposed to catch this, but of course it didn't since
all our distros now have newer versions than this.
Now when glib was introduced Daniel provided the following analysis of
glib versions:
RHEL-8: 2.56.1
RHEL-7: 2.50.3
Debian (Buster): 2.58.3
Debian (Stretch): 2.50.3
OpenBSD (Ports): 2.58.3
FreeBSD (Ports): 2.56.3
OpenSUSE Leap 15: 2.54.3
SLE12-SP2: 2.48.2
Ubuntu (Xenial): 2.48.0
macOS (Homebrew): 2.56.0
Lets have an updated version of this list in the commit message please.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|