Re: [libvirt] [PATCH 0/9] Use the systemd journal for logging
On Thu, Sep 27, 2012 at 07:31:41PM -0500, Doug Goldstein wrote:
On Thu, Sep 27, 2012 at 11:44 AM, Daniel P. Berrange
<berrange(a)redhat.com> wrote:
> The systemd journal provides a highly efficient way for apps
> to generate structured log messages. Since systemd will be
> used by default on future Fedora/RHEL distros (and likely
> many others), we should take advantage of the journal out of
> the box for improved logging capabilities.
>
> Amongst other things, this allows very easy browsing of the
> libvirt logs after the fact, filtering on filename / line
> number / function name and more. This is a big benefit
> to debugging, compared to current case where we need to
> decide the filters when starting libvirtd. For example
> it becomes possible to configure libvirt to include all
> QEMU logging, and then later ask the journal for only
> messages related to the QEMU json monitor.
>
> --
Someone else posted a patchset for structured logging via lumberjack
which would support systemd as well as the other syslog daemons in an
abstract way without directly tying the project to systemd?
That seems like a better option IMHO. So I would vote for a NACK for the series.
First off, we're not tieing the project to systemd, because this is an
entirely optional feature. If you read my response to the lumberjack
posting, you'll see that there are a number of serious architectural
flaws in the design of lumberjack for use as a structured logging
system. Unless they radically change the design, which appears unlikely,
it is not going to be suitable as a logging impl for libvirt (or arguably
any system daemon) to use.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|