Re: [libvirt] [PATCH 1/3] qemu: block: Use correct type when creating image size JSON entries
On Fri, Aug 30, 2019 at 04:45:03PM +0200, Peter Krempa wrote:
The 'u' modifier creates a unsigned int JSON attribute but the
disk size
an unsigned
and capacity fields are unsigned long long. If the size of the
created
image would be more than 4GiB we'd overflow and create sub-4G image.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_block.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Depending on how broken things get,
qemuBlockStorageSourceGetGlusterProps might need a similar change ;)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)