Re: [libvirt] [PATCH 02/18] util: storagefile: Always store raw backing name in the metadata
On 04/20/2014 04:13 PM, Peter Krempa wrote:
Don't use the backingStoreRaw as a indication of broken chains.
Fill it
always and tweak the broken image chain detector to avoid changing the
semantics.
The new semantics to detect a broken chain is the presence of string in
backingStoreRaw but the lack of the backing chain metadata structure in
the chain.
Yay - you were able to take this where I had been aiming to go before I
got interrupted by real life (TM) last week :)
Now that the raw backing store name is always filled there's no need to
pass the raw name variable separately to fill in case the backing is not
a file. Tweak the function so that it can handle a NULL in that case.
---
src/util/virstoragefile.c | 51 +++++++++++++++++++----------------------------
1 file changed, 21 insertions(+), 30 deletions(-)
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)