[libvirt] Re: [PATCH 0/7] Series short description
Quoting Amy Griffis (amy.griffis(a)hp.com):
The following patches fix logging for the lxc controller. The lxc
controller makes use of the libvirt logging module, but because it
doesn't re-initialize the logging configuration the messages are
currently going nowhere.
There are a couple of options in fixing this. The lxc controller could
use libvirtd's logging configuration exactly, or it adopt a more
independent mode of logging to the container log file. After talking
with Daniel Veillard a while back, it seemed clear that both behaviors
are desirable. I resolved this by adding a lxc.conf file for the lxc
driver, with a boolean variable to toggle between modes.
I hope this looks good to both libvirt and container folks.
No complaints from me. As I recall logging was indeed a problem when I
was debugging, so it sounds like this will help - thanks. Brief look
through the patches didn't raise any obvious problems, though I'm also
not familiar with the libvirt code being patched.
thanks,
-serge
libvirt.spec.in | 16 ++++++
src/Makefile.am | 25 +++++++--
src/libvirt_private.syms | 3 +
src/lxc/libvirtd_lxc.aug | 30 +++++++++++
src/lxc/lxc.conf | 13 +++++
src/lxc/lxc_conf.c | 24 +++++++++
src/lxc/lxc_conf.h | 1
src/lxc/lxc_controller.c | 3 +
src/lxc/lxc_driver.c | 86 ++++++++++++++++++++++++++++----
src/lxc/test_libvirtd_lxc.aug | 31 ++++++++++++
src/util/logging.c | 109 ++++++++++++++++++++++++++++++++++++++---
src/util/logging.h | 14 +++++
src/util/util.c | 49 ++++++++++++++++++
src/util/util.h | 3 +
14 files changed, 379 insertions(+), 28 deletions(-)
create mode 100644 src/lxc/libvirtd_lxc.aug
create mode 100644 src/lxc/lxc.conf
create mode 100644 src/lxc/test_libvirtd_lxc.aug
Regards,
Amy