Re: [libvirt] [PATCH v2 2/8] tests: qemuxml2xml: Always use different output file
On Fri, Jan 22, 2016 at 02:09:18PM -0500, Cole Robinson wrote:
Most qemuxml2xml tests expect that the input XML is unchanged after
parsing. This is unlike 99% of new qemu configs in the wild, which after
initial parsing end up with stable PCI device addresses. The xml2xml bit
doesn't currently hit that code path though, so most XML testing indeed
does not change.
Future patches will add that PCI address bits, which means most test cases
will have different output. So let's do away with the hardcoded same vs
different test split, and always track a separate output file. Tests can
still have same input and output, it just necessitates 2 separate XML files.
I don't know whether there was a discussion behind this, if there was, I
regret missing it. I don't like this very much as it's not visible from
the test if that file should change or not. It is visible in the files,
but you have to diff them. If we really need this, I suggest using
symlinks to save some space and also time as it will be clearer which
XMLs are the same and which are not.
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)