Re: [libvirt] [PATCH 1/2] qemu: Properly report error state in qemuDomainGetControlInfo()
On Thu, Feb 19, 2015 at 12:02:27PM +0100, Peter Krempa wrote:
Previously when a domain would get stuck in a domain job due to a
programming mistake we'd report the following control state:
$ virsh domcontrol domain
occupied (1424343406.150s)
The timestamp is invalid as the monitor was not entered for that domain.
We can use that to detect that the domain has an active job and report a
better error instead:
$ virsh domcontrol domain
error: internal (locking) error
I don't really think that is much better as it still doesn't give us any
clue as to how/why we got into this broken state.
I think it'd be desirable to modify our JobEnter APIs so that they get
passed the __FUNC__ __FILE__ and __LINE__ of the code which starts the
job. Then include this info when we report a job error.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|