Re: [libvirt] [PATCH 10/12] tests: qemuxml2xml: Use testQemuInfoSetArgs
On Wed, 2019-04-10 at 18:53 -0400, Cole Robinson wrote:
On 4/10/19 12:53 PM, Andrea Bolognani wrote:
> I haven't really spent any time digging, but that call to
> qemuTestCapsCacheInsert() looks odd to me. What exactly is the point
> in caching if we're going to be using a different set of capabilities
> pretty much every single time?
IIRC it's not really about caching or speed or whatever, it's required
to get our manually populated qemuCaps into the standard src/qemu driver
routines, which use virQEMUCapsCacheLookup everywhere
Yeah, I realized the motivation on my own while getting to the
office this morning. A good night's sleep always helps see things
more clearly :)
--
Andrea Bolognani / Red Hat / Virtualization