Re: [libvirt] [PATCH] virsh: change printf() calls to vshPrint()

On Wed, Jun 16, 2010 at 03:25:05PM +1000, Justin Clift wrote: > Trivial fix changing printf() calls to vshPrint() where the ctl > variable is available. > --- > > Haven't created a BZ for this yet, as I'm not sure it's important enough > to warrant pushing into anything other than git head. > > Should a BZ be created anyway?

> case VIR_DOMAIN_SCHED_FIELD_INT: > - printf("%-15s: %d\n", params[i].field, params[i].value.i); > + vshPrint(ctl, "%-15s: %d\n", params[i].field, params[i].value.i); ACK, looks fine to me. Though I do wonder why we bother having a wrapper around printf at all, given that it just does #define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__) but that's a story for another day :-)