Re: [libvirt] [PATCH v4 10/20] backup: Implement backup APIs for remote driver
On 2/6/19 2:18 PM, Eric Blake wrote:
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, at which point the remote driver
code for backups can be generated.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/remote/remote_daemon_dispatch.c | 22 ++-
src/remote/remote_driver.c | 33 +++-
src/remote/remote_protocol.x | 238 +++++++++++++++++++++++++++-
src/remote_protocol-structs | 129 +++++++++++++++
src/rpc/gendispatch.pl | 32 ++--
5 files changed, 434 insertions(+), 20 deletions(-)
Some of this could change as a result of earlier review comments -
vis-a-vis API names, but otherwise looks fine to my eyes.
I'm by no means a perl expert - it looks like the right pieces were
copied and/or extract.
John
[...]