Re: [libvirt] [PATCH 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

>> if WITH_LIBXL >> libvirtd_LDADD += ../src/libvirt_driver_libxl.la >> + libvirtd_LDADD += ../src/libvirt_xenxs.la >> + libvirtd_LDADD += ../src/libvirt_util.la >> + libvirtd_LDADD += ../src/libvirt_conf.la >> endif >> > > I'd like to get another opinion on this hunk. Although I cant find any > issues with it, I'd just like to ensure there is not a more appropriate > way to add these libs. libvirtd is linked against libvirt.so, so it is already able to get access to any symbols in libvirt_util.la or libvirt_conf.la, *provided* the symbols are listed in libvirt_private.syms. I'm guessing there were one or two not listed in the private exports file, making it appear that these extra linker lines were needed. Just add the extra symbols to that file and you should be fine