Re: [libvirt] [PATCH] Detect bridge name collisions when defining a virtual network
On Mon, Feb 16, 2009 at 06:39:54PM -0500, Cole Robinson wrote:
The attached patch is a partial fix for rhbz 479622. If a virtual
network is defined with an explicit bridge name, make sure it doesn't
collide with other virtual network bridge names.
+int virNetworkBridgeInUse(const virNetworkObjListPtr nets,
+ const char *bridge)
+{
+ unsigned int i;
+
+ for (i = 0 ; i < nets->count ; i++) {
+ if (nets->objs[i]->def->bridge &&
+ STREQ(nets->objs[i]->def->bridge, bridge))
+ return 1;
+ }
+
This isn't thread-safe - you need to use virNetworkObjLock/Unlock
around each access, and mandate that the network driver is locked
before calling this.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|