Re: [libvirt] [PATCH V3 1/2] libxl: drop support for Xen < 4.6

On Tue, Sep 11, 2018 at 04:38:26PM -0600, Jim Fehlig wrote: > Currently the libxl driver claims support for Xen >= 4.4, but > Xen 4.4 and 4.5 are no longer supported upstream. Let's increase > the minimum supported Xen version to 4.6 and change the defined > LIBXL_API_VERSION to 0x040500, which is the API version defined > when Xen 4.6 was released. > > Since Xen 4.6 contains a pkgconfig file, drop the now unused code > that falls back to using LIBVIRT_CHECK_LIB in the absence of > pkgconfig file. In addition, bumping the LIBXL_API_VERSION > required adjusting the calls to libxl_set_vcpuaffinity to account > for the extra parameter in the 0x040500 version of the API. > > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; > --- > > I made some other changes to this patch so have not added Michal's > ACK from V2. Changes in V3: > > - Change definition of LIBXL_API_VERSION to 0x040500, the API >  version set when Xen 4.6 was released > - Drop the 'true' parameter to LIBVIRT_CHECK_PKG macro so >  configure fails if libxl is requested but the devel packages >  are not installed > - Remove a now unused variable and a redundant 'if test with_libxl' >  check > > docs/drvxen.html.in      |  2 +- > m4/virt-driver-libxl.m4  | 27 ++------------------------- > src/libxl/libxl_domain.c |  2 +- > src/libxl/libxl_driver.c |  2 +- > 4 files changed, 5 insertions(+), 28 deletions(-) > Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt;

The check for libxl_domain_config_from_json can also be dropped.