Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project
On Mon, 2017-10-02 at 17:04 +0100, Daniel P. Berrange wrote:
> +- name: '{{ project }}: Run sanity checks'
> + command: '{{ make }} -j{{ smp }} syntax-check'
> + args:
> + chdir: '{{ project }}'
> + when:
> + - project == 'libosinfo'
This looks like its duplicating the rules we already have
defined in the jobs/ files for Jenkins. Why do we need
this ?
It's explained in the commit message for patch 2:
Building projects is entirely controlled by Jenkins in a production
environment, but it can be useful to trigger builds via Ansible
during development to figure out build dependencies and for sanity
checking purposes.
I'm not adamant on keeping this around, as it was mainly a tool
for me to use during development, but I figure it might come in
handy later on when some project picks up new (optional) build
dependencies or we need to add a new project, and I'd rather not
have to reinvent the wheel when that happens.
Note that none of those tasks is executed unless you manually set
the 'build' variable to true, so they will not interfere in any
way with regular CI usage.
--
Andrea Bolognani / Red Hat / Virtualization