Re: [libvirt] [PATCH 2/5] Remove windows thread implementation in favour of pthreads

On 01/23/2014 05:37 AM, Daniel P. Berrange wrote: > There are a number of pthreads impls available on Win32 > these days, in particular the mingw64 project has a good > impl. Delete the native windows thread implementation and > rely on using pthreads everywhere. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > configure.ac | 15 +- > src/Makefile.am | 4 - > src/util/virthread.c | 291 +++++++++++++++++++++++++++++++- > src/util/virthread.h | 41 ++++- > src/util/virthreadpthread.c | 309 ---------------------------------- > src/util/virthreadpthread.h | 53 ------ > src/util/virthreadwin32.c | 396 -------------------------------------------- > src/util/virthreadwin32.h | 53 ------ > 8 files changed, 329 insertions(+), 833 deletions(-) > delete mode 100644 src/util/virthreadpthread.c > delete mode 100644 src/util/virthreadpthread.h > delete mode 100644 src/util/virthreadwin32.c > delete mode 100644 src/util/virthreadwin32.h This works for Fedora 20, but is it going to work on F19? What about RHEL (or does RHEL not care about mingw builds?) While I'm in favor of reducing the duplication, I'm wondering if we should still wait a bit longer before assuming winpthreads is reliably available for mingw.