Re: [libvirt] [PATCH 3/6] qemu: driver: Save status XML when starting a block job
On 10/04/2017 07:59 AM, Peter Krempa wrote:
Few jobs (which don't) use the 'mirror' element did not
save the status
XML. It will be helpful to do so once we start tracking jobs fully.
---
src/qemu/qemu_driver.c | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
[...]
@@ -17311,6 +17317,7 @@ qemuDomainBlockCommit(virDomainPtr dom,
unsigned int flags)
{
virQEMUDriverPtr driver = dom->conn->privateData;
+ virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
qemuDomainObjPrivatePtr priv;
virDomainObjPtr vm = NULL;
char *device = NULL;
There's a :
virCheckFlags(VIR_DOMAIN_BLOCK_COMMIT_SHALLOW |... , -1);
that will leak cfg... with obvious adjustment...
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
[...]