Re: [libvirt] [PATCH 6/8] Remove virConnectPtr from interface XML APIs
On Wed, Feb 10, 2010 at 01:36:24PM +0000, Daniel P. Berrange wrote:
The virConnectPtr is no longer required for error reporting since
that is recorded in a thread local. Remove use of virConnectPtr
from all APIs in interface_conf.{h,c} and update all callers to
match
---
src/conf/interface_conf.c | 259 ++++++++++++++++++++----------------------
src/conf/interface_conf.h | 15 +--
src/interface/netcf_driver.c | 8 +-
src/test/test_driver.c | 16 ++--
tests/interfacexml2xmltest.c | 4 +-
5 files changed, 141 insertions(+), 161 deletions(-)
[...]
@@ -890,26 +883,24 @@ virInterfaceDefPtr
virInterfaceDefParseString(virConnectPtr conn,
if (!pctxt || !pctxt->sax)
goto cleanup;
pctxt->sax->error = catchXMLError;
- pctxt->_private = conn;
- if (conn) virResetError (&conn->err);
Hum, there there is a semantic change, the function used to reset
the error and not anymore, though it's probably better that way
@@ -930,26 +920,24 @@ virInterfaceDefPtr
virInterfaceDefParseFile(virConnectPtr conn,
if (!pctxt || !pctxt->sax)
goto cleanup;
pctxt->sax->error = catchXMLError;
- pctxt->_private = conn;
- if (conn) virResetError (&conn->err);
Here too
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/