Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

"Daniel P. Berrange" <berrange(a)redhat.com&gt; writes: > On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: >> Some CDROM devices are reported by udev to have an ID_TYPE="generic" >> thus it is necessary to check if ID_CDROM is present. >> >> As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will >> enable checks for ID_DRIVE_FLASH_SD and ID_DRIVE_FLOPPY and the >> udevKludgeStorageType heuristic. >> >> Signed-off-by: Giuseppe Scrivano <gscrivan(a)redhat.com&gt; >> --- >> src/node_device/node_device_udev.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) > > ACK Thanks. Can somebody please push the patch as I've no write access to the repo?