Re: [PATCH v2 2/5] hw/nvme: do not auto-generate eui64
On Fri, Apr 29, 2022 at 10:33:33AM +0200, Klaus Jensen wrote:
From: Klaus Jensen <k.jensen(a)samsung.com>
We cannot provide auto-generated unique or persistent namespace
identifiers (EUI64, NGUID, UUID) easily. Since 6.1, namespaces have been
assigned a generated EUI64 of the form "52:54:00:<namespace counter>".
This is will be unique within a QEMU instance, but not globally.
Revert that this is assigned automatically and immediately deprecate the
compatibility parameter. Users can opt-in to this with the
`eui64-default=on` device parameter or set it explicitly with
`eui64=UINT64`.
Looks good:
Reviewed-by: Christoph Hellwig <hch(a)lst.de>