Re: [libvirt] [RFC] Power Hypervisor Libvirt support

> > @@ -714,6 +716,21 @@ AM_CONDITIONAL([HAVE_NUMACTL], [test "$with_numactl" != "no"]) > > AC_SUBST([NUMACTL_CFLAGS]) > > AC_SUBST([NUMACTL_LIBS]) > > > > +if test "$with_phyp" = "yes"; then > > + AC_CHECK_LIB([ssh],[ssh_new],[ > > + LIBSSH_LIBS="$LIBSSH_LIBS -lssh -L/usr/local/lib/" > > + AC_SUBST([LIBSSH_LIBS])],[ > > + AC_MSG_ERROR([You must install the libssh to compile Phype driver.])]) > > + > > + AC_CHECK_HEADERS([libssh/libssh.h],[ > > + LIBSSH_CFLAGS="-I/usr/local/include/libssh" > > + AC_SUBST([LIBSSH_CFLAGS])],[ > > + AC_MSG_ERROR([Cannot find libssh headers.Is libssh installed ?])],[]) > > + AC_DEFINE_UNQUOTED([WITH_PHYP], 1, > > + [whether IBM HMC / IVM driver is enabled]) > > +fi > > +AM_CONDITIONAL([WITH_PHYP],[test "$with_phyp" = "yes"]) > > For this it is preferable to avoid using hardcoded paths in this way. If > we are going to use libssh2 for phyp driver, then I reckon it woul dbe > desirable to also use it for our existing remote RPC driver too (it currently > just fork/exec's /usr/bin/ssh). In fact I use libssh <http://0xbadc0de.be/wiki/libssh:libssh> and not libssh2. I choosed libssh instead of libssh2 for some reasons: libssh2 doesn't handle server side ssh or sshv1. And I am more used to work with its API then libssh2.