On Fri, Apr 15, 2016 at 09:21:49 +0200, Martin Kletzander wrote:
So in glibc-2.23 sys/sysmacros.h is no longer included from
sys/types.h
and we don't build because of the usage of major/minor/makedev macros.
Autoconf already has AC_HEADER_MAJOR macro that check where exactly
these functions/macros are defined, so let's use that.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
v2:
- Don't include the file unconditionally, but rather use
AC_HEADER_MAJOR that exists for exactly this purpose.
v1:
-
https://www.redhat.com/archives/libvir-list/2016-April/msg00851.html
configure.ac | 2 ++
src/conf/domain_audit.c | 6 ++++++
src/lxc/lxc_controller.c | 7 +++++++
src/lxc/lxc_driver.c | 7 +++++++
src/util/vircgroup.c | 7 +++++++
src/util/virutil.c | 7 +++++++
tests/vircgroupmock.c | 7 +++++++
7 files changed, 43 insertions(+)
I've just found out about the breakage by upgrading glibc and almost
blamed you as I've misunderstood this patch.
This fixes the build for me and the usage of AC_HEADER_MAJOR looks on
the spot to me.
ACK