Re: [libvirt] [PATCH 5/6] RFC qemu: add spice opengl support
On Tue, Nov 24, 2015 at 03:50:02PM +0100, Marc-André Lureau wrote:
Hi Jan
On Mon, Nov 23, 2015 at 6:58 PM, Ján Tomko <jtomko(a)redhat.com> wrote:
> Overall, the XML looks good to me. Apart from the accel3d attribute,
> which is ugly, but less ugly than inveting a separate one.
Thanks for your feedback.
While reworking the patches and adding xml2xml test, I realized the
accel2d/3d is a simple bool, so
<model type='virtio' heads='1'>
<acceleration accel3d='yes'/>
</model>
Is turned into:
<model type='virtio' heads='1'>
<acceleration accel3d='yes' accel2d='no'/>
</model>
Would it be backward incompatible if we changed it to a tristate?
I think making it a tristate is fine and in fact very desirable
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|