Re: [libvirt] [PATCH] build: use LIBADD, not LDFLAGS, for adding libraries
On 05/07/2010 11:18 AM, Jim Meyering wrote:
> @@ -686,7 +692,8 @@ endif
> libvirt_driver_secret_la_CFLAGS = \
> -I@top_srcdir@/src/conf
> if WITH_DRIVER_MODULES
> -libvirt_driver_secret_la_LDFLAGS = -module -avoid-version ../gnulib/lib/libgnu.la
> +libvirt_driver_secret_la_LDFLAGS = -module -avoid-version
> +libvirt_driver_secret_la_LDAD = ../gnulib/lib/libgnu.la
Oops. That should be ..._LDADD
Or better, LIBADD. Automake didn't warn about the typo, because it
wasn't a primitive, but it did warn about LDADD. Fixed.
> endif
> libvirt_driver_secret_la_SOURCES = $(SECRET_DRIVER_SOURCES)
Other than that, it looks fine. Thanks.
Thanks for the review; pushed.
Did everything build/link with that for you? (I didn't try.)
Yes, 'make clean; make check' passed on my F12 system, and I think I
have all of the prereq dev libraries installed to exercise the bulk of
the libraries.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)