Re: [libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

On 08/03/2015 06:23 PM, Ján Tomko wrote: > On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote: >> PowerPC pseries based VMs do not support a floppy disk controller. > Here the commit message mentions a controller, but the code only checks > for the <disk type='floppy'/> device, > not for <controller type='fdc'/> > > Should we forbid that one too? AFAIK we've auto-added it to the XML > only if there was at least floppy. We need not forbid fdc, as checking for floppy device will fulfill the need. Yes, fdc is added only if there was at least one floppy device.