Re: [libvirt] [PATCH 18/24] maint: improve VIR_ERR_INVALID_NODE_DEVICE usage
On 12/28/2013 11:11 AM, Eric Blake wrote:
While all errors related to invalid node device appeared to be
consistent, we might as well continue the trend of using a
common macro. For now, we don't need virCheckNodeDeviceGoto().
* src/datatypes.h (virCheckNodeDeviceReturn): New macro.
(VIR_IS_NODE_DEVICE, VIR_IS_CONNECTED_NODE_DEVICE): Drop
unused macros.
* src/libvirt.c: Use macro throughout.
(virLibNodeDeviceError): Drop unused macro.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/datatypes.h | 17 +++++++++---
src/libvirt.c | 83 ++++++++++-----------------------------------------------
2 files changed, 27 insertions(+), 73 deletions(-)
ACK
John