Re: [libvirt] [PATCH v5 03/14] audio: -audiodev command line option: documentation
On Fri, Feb 22, 2019 at 03:22:35PM +0100, Gerd Hoffmann wrote:
Hi,
> > * deprecated QEMU_AUDIO_ env vars
>
> Libvirt does currently use these, so we'll need to update libvirt
> code to use the new cli args
Note: The old vars will continue to work, and possibly it makes sense to
keep at least QEMU_AUDIO_DRV (which I think is the only one used by
libvirt) working a bit longer than the minimal deprecation period.
We can do the trivial replacement of QEMU_AUDIO_DRV with -audiodev
without much difficulty - just a matter of tweaking the CLI generator
and tests.
The full support with XML configurability doesn't need to block us
dropping use of QEMU_AUDIO_DRV.
Also: This is a first step only, there is more in the pipeline,
where
you can assign sound cards to backends (simliar to -netdev). You might
want wait for this to land before start working on libvirt support, or
at least keep in bind this is coming when designing things.
Libvirt lacks proper support for the existing multi-seat features in
QEMU. This audio stuff might be a good motivation to finally implement
the full multi-seat feature set.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|