Re: [libvirt] [PATCH 5/7] cfg.mk: drop redundant sc_prohibit_gethostby

Both gethostbyaddr and gethostbyname* are already checked by sc_prohibit_nonreentrant.

--- cfg.mk | 9 --------- 1 file changed, 9 deletions(-) diff --git a/cfg.mk b/cfg.mk index 0604d69..9f236c2 100644 --- a/cfg.mk +++ b/cfg.mk @@ -520,13 +520,6 @@ sc_forbid_manual_xml_indent: halt='use virBufferAdjustIndent instead of spaces when indenting xml' \ $(_sc_search_regexp) -# Not only do they fail to deal well with ipv6, but the gethostby* -# functions are also not thread-safe. -sc_prohibit_gethostby: - @prohibit='\<gethostby(addr|name2?) *\(' \ - halt='use getaddrinfo, not gethostby*' \ - $(_sc_search_regexp) - # dirname and basename from <libgen.h> are not required to be thread-safe sc_prohibit_libgen: @prohibit='( (base|dir)name *\(|include .libgen\.h)' \ @@ -1192,8 +1185,6 @@ exclude_file_name_regexp--sc_prohibit_strncpy = ^src/util/virstring\.c$$ exclude_file_name_regexp--sc_prohibit_strtol = ^examples/.*$$ -exclude_file_name_regexp--sc_prohibit_gethostby = ^docs/nss.html.in$$ - exclude_file_name_regexp--sc_prohibit_xmlGetProp = ^src/util/virxml\.c$$ exclude_file_name_regexp--sc_prohibit_xmlURI = ^src/util/viruri\.c$$