Re: [libvirt] [PATCH 03/10] tests: Break out duplicate schema verification functionality.

2009/10/12 Cole Robinson <crobinso(a)redhat.com&gt;: > All schema tests have identical functionality, so avoid the duplication. > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > --- >  tests/Makefile.am      |   1 + >  tests/capabilityschematest  |  34 ++++------------------------------ >  tests/domainschematest    |  33 ++++----------------------------- >  tests/interfaceschematest  |  31 +++---------------------------- >  tests/networkschematest   |  30 +++--------------------------- >  tests/nodedevschematest   |  31 +++---------------------------- >  tests/schematestutils.sh   |  39 +++++++++++++++++++++++++++++++++++++++ >  tests/storagepoolschematest |  31 +++---------------------------- >  tests/storagevolschematest  |  30 +++--------------------------- >  9 files changed, 63 insertions(+), 197 deletions(-) >  create mode 100644 tests/schematestutils.sh Your patch adds some bashisms. This prevents make check from running successfully on Debian/Ubuntu, because their default shell is dash and not bash. The attached patch removes this bashisms. Matthias