Re: [libvirt] [PATCH] spec: Fix permissions of nwfilter XMLs

On Thu, 2019-05-23 at 14:56 +0200, Jiri Denemark wrote: [...] > %post daemon-config-nwfilter > cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ > +# libvirt saves these files with mode 600 > +chmod 600 %{_sysconfdir}/libvirt/nwfilter/*.xml > # Make sure libvirt picks up the new nwfilter defininitons > mkdir -p %{_localstatedir}/lib/rpm-state/libvirt || : > touch %{_localstatedir}/lib/rpm-state/libvirt/restart || : Interesting, I have the very same hunk in a larger patch that I'm working on :) The change itself looks good, but shouldn't you be able to remove the corresponding call from the %install section at the same time? It's not like it's doing anything useful at the moment anyway.