Re: [libvirt] [PATCH] security: plug regression introduced in disk probe logic

>> +++ b/src/security/security_manager.c >> @@ -107,7 +107,7 @@ virSecurityManagerPtr virSecurityManagerNew(const char *name, >> >> void *virSecurityManagerGetPrivateData(virSecurityManagerPtr mgr) >> { >> - return ((char*)mgr) + sizeof(mgr); >> + return ((char*)mgr) + sizeof(*mgr); > > I suppose I could have used: > > return mgr + 1; > > instead, since that gives the same address with less typing. Any > preferences on which form to commit? > I'd say go with the more readable mgr + 1.