Re: [libvirt] [PATCH] Added snapshot backing store parameters to virsh vol-create-as.
On 06/06/2010 07:09 PM, Justin Clift wrote:
---
tools/virsh.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
tools/virsh.pod | 7 ++++++-
2 files changed, 57 insertions(+), 2 deletions(-)
This is the resubmitted patch, now checking the given volume string as a
path and key if not found as a volume name.
Also now alters the user if the volume isn't found, plus includes level
5 debugging output in case it's useful.
As a style thought, I generally put a fair number of comments in the
code I write. Not seeing many in the existing virsh.c code, so does
that mean they shouldn't be included?
Regards and best wishes,
Justin Clift
--
Salasaga - Open Source eLearning IDE
http://www.salasaga.org