On 08/30/2016 12:52 AM, Cedric Bosdonnat wrote:
On Mon, 2016-08-29 at 11:20 -0600, Jim Fehlig wrote:
> The libxl driver has long supported migration V3 but has never
> indicated so in the connectSupportsFeature API. As a result, apps
> such as virt-manager that use the more generic virDomainMigrate API
> fail with
>
> libvirtError: this function is not supported by the connection driver:
> virDomainMigrate
>
> Add VIR_DRV_FEATURE_MIGRATION_V3 to the list of features marked as
> supported in the connectSupportsFeature API.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> src/libxl/libxl_driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index a573c82..3ffaa74 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -5677,6 +5677,7 @@ libxlConnectSupportsFeature(virConnectPtr conn, int feature)
> return -1;
>
> switch (feature) {
> + case VIR_DRV_FEATURE_MIGRATION_V3:
> case VIR_DRV_FEATURE_TYPED_PARAM_STRING:
> case VIR_DRV_FEATURE_MIGRATION_PARAMS:
> case VIR_DRV_FEATURE_MIGRATION_P2P:
ACK
Thanks. Since this is a trivial bug fix, and given a second review by Joao, I've
pushed this for RC2.
Regards,
Jim