Re: [libvirt] [PATCH] Fix virsh {net,pool}-edit

Cole Robinson <crobinso(a)redhat.com&gt; wrote: > The dumpxml commands for networks and pools don't support any flag > arguments, and in fact explictly fail if flags != 0. This is not the > case for vm dumpxml though, and flags were added to the base 'edit' > implementation in virsh recently. > > The net and pool derivatives were not addressing this difference, so any > net-edit or pool-edit attempt currently gives an error like: > > Network error : invalid argument in virNetworkGetXMLDesc > > The attached patch is one way to fix this. Thanks to Charles Duffy for > the report. Hi Cole, That looks good to me. I confirmed it fixes the bug when using the qemu-based driver: cat <<EOF > net.xml <network> <name>N</name> <ip address="192.168.199.1" netmask="255.255.255.0"></ip> </network> EOF printf '#!/bin/sh\nperl -pi -e "s/199/19/" "$@"\n' > ed; chmod +x ed qemud/libvirtd & EDITOR=$PWD/ed src/virsh 'net-define net.xml; net-edit N' However, using the test driver, my little test exposed a bug: EDITOR=$PWD/ed src/virsh -c test:///default 'net-define net.xml; net-edit N' zsh: segmentation fault That was because the "def = NULL" assignment (to make it so the upcoming "free" is a no-op) is too early, since there are uses of def right after that. And the same bug appears in 3 other nearby functions. Here's the fix I'll commit soon, along with tests based on the above.