Re: [libvirt] [PATCH] virfile: added GPFS as shared fs

On Mon, Feb 25, 2019 at 19:19:03 +0100, Diego Michelotto wrote: > From: dmichelotto <diego.michelotto(a)cnaf.infn.it&gt; With your permission I'll remove the above line when applying the patch so that your authorship of the patch shows up as: Author: Diego Michelotto <diego.michelotto(a)cnaf.infn.it&gt; instead of Author: dmichelotto <diego.michelotto(a)cnaf.infn.it&gt; > > Added GPFS as shared file system recognized during live migration > security checks. > > GPFS is 'IBM General Parallel File System' also called > 'IBM Spectrum Scale' > > BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1679528 > > Signed-off-by: Diego Michelotto <diego.michelotto(a)cnaf.infn.it&gt; > --- > src/util/virfile.c | 9 ++++++++- > src/util/virfile.h | 1 + > tests/virfiledata/mounts3.txt | 1 + > tests/virfilemock.c | 5 +++++ > tests/virfiletest.c | 1 + > 5 files changed, 16 insertions(+), 1 deletion(-) One thing which might be worth exploring is whether GPFS is also migratable with cache != none and thus should be also added to virStorageFileIsClusterFS. ACK. Depending on the angle of view this can be viewed both as a bug and as a feature. Since we are feature freeze, is anybody objecting in pushing this right away? (obviously I'm not going to push it right now)